since markdown notes might be rather long, this commit adds a tab similar to pve's datacenter or node notes. requires a bump of the widget toolkit in order to use the `pmxNotesView`.
Signed-off-by: Stefan Sterz <s.st...@proxmox.com> --- the maxLength of a note in pbs is chosen to be 1022*64 because the server allows at most 1024*64 bytes of form data per request, which are distributed as follows: equal signs: 2 the word "digest": 7 digest: 64 the word "description": 12 description: 65451 so by setting the limit to 1024*64 some users might encounter an error telling them that the message body was too large even though the front-end said the description was fine. i wanted to approximate the 1024*64 limit here as close as possible so i chose: 65451 / 64 ~ 1022. note that afaict due to the way maxLength is implemented the limit will still sometimes not be correct. this is due to character encodings and how javascript's string length property works. www/Makefile | 1 + www/NavigationTree.js | 6 ++++++ www/NodeNotes.js | 23 +++++++++++++++++++++++ 3 files changed, 30 insertions(+) create mode 100644 www/NodeNotes.js diff --git a/www/Makefile b/www/Makefile index 455fbeec..922d8de9 100644 --- a/www/Makefile +++ b/www/Makefile @@ -98,6 +98,7 @@ JSSRC= \ datastore/DataStoreList.js \ ServerStatus.js \ ServerAdministration.js \ + NodeNotes.js \ Dashboard.js \ ${TAPE_UI_FILES} \ NavigationTree.js \ diff --git a/www/NavigationTree.js b/www/NavigationTree.js index 576d05ab..916582ef 100644 --- a/www/NavigationTree.js +++ b/www/NavigationTree.js @@ -32,6 +32,12 @@ Ext.define('PBS.store.NavigationStore', { path: 'pbsDashboard', leaf: true, }, + { + text: gettext('Notes'), + iconCls: 'fa fa-sticky-note-o', + path: 'pbsNodeNotes', + leaf: true, + }, { text: gettext('Configuration'), iconCls: 'fa fa-gears', diff --git a/www/NodeNotes.js b/www/NodeNotes.js new file mode 100644 index 00000000..f8b253c4 --- /dev/null +++ b/www/NodeNotes.js @@ -0,0 +1,23 @@ +// Needs to be its own xtype for `path` to work in `NavigationTree` +Ext.define('PBS.NodeNotes', { + extend: 'Ext.panel.Panel', + xtype: 'pbsNodeNotes', + + scrollable: true, + layout: 'fit', + + items: [ + { + xtype: 'container', + layout: 'fit', + items: [{ + xtype: 'pmxNotesView', + tools: false, + border: false, + node: 'localhost', + enableTBar: true, + maxLength: 1022*64, + }], + }, + ], +}); -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel