On 6/30/22 13:02, Dietmar Maurer wrote:
in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing...diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 99b426e..c6a3ac1 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2102,7 +2102,7 @@ __PACKAGE__->register_method({} else { - $ENV{LC_PVE_TICKET} = $password if $websocket; # set ticket with "qm vncproxy"+ $ENV{LC_PVE_TICKET} = $password;$cmd = [@$remcmd, "/usr/sbin/qm", 'vncproxy', $vmid];
AFAICS, this is a remnant of old code where we would start wsproxy.py instead of our 'qm vncproxy' i think we could remove the whole websocket parameter as it doesn't do anything here so we could do 1. remove the use of $websocket here 2. remove the websocket=1 parameter in novnc 3. remove the websocket parameter completely (in 8.0, since it's a breaking api change) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
