With the Usage::Static plugin, scoring is not as cheap anymore and select_service_node() is called for each running service.
This should cover most calls of select_service_node(). Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> --- I think the whole $found logic can be dropped *if* we ensure that $tried_nodes and $try_next go hand in hand, because all the tried nodes are already not considered as candidates anymore. But this has to be evaluated more carefully and is something for after the release of course :) The test_failover1.pl test doesn't set failed nodes at all and would be the only one to break. src/PVE/HA/Manager.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index b94ba9d..9d36ea8 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -152,6 +152,8 @@ sub select_service_node { return $maintenance_fallback if defined($maintenance_fallback) && $pri_groups->{$top_pri}->{$maintenance_fallback}; + return $current_node if !$try_next && $pri_groups->{$top_pri}->{$current_node}; + my $scores = $online_node_usage->score_nodes_to_start_service($sid, $current_node); my @nodes = sort { $scores->{$a} <=> $scores->{$b} || $a cmp $b @@ -171,8 +173,6 @@ sub select_service_node { } else { return $nodes[0]; } - } elsif (defined($found)) { - return $nodes[$found]; } else { return $nodes[0]; } -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel