...when editing LDAP realm sync settings and only a single property is empty and thus to be deleted (e.g. values.delete = "filter").
If `delete` is a simple string and not an array, `PVE.Utils.delete_if_default` simply creates a comma-separated list, (e.g. value.delete = "filter,sync-attributes"). When the properties from the other panel are evaluated and added to the the `delete` property, comma-separated list format is not considered, leading to a final value for `delete` that could look like this: value.delete = { "server2", "comment", "filter,sync-attributes" } This commit fixes this by splitting `delete` in case it is a string. Reported-by: Friedrich Weber <f.we...@proxmox.com> Signed-off-by: Lukas Wagner <l.wag...@proxmox.com> --- Same fix as in my LDAP widget-toolkit patch series: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005952.html www/manager6/dc/AuthEditLDAP.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js index 96ef77b9..2ce16e58 100644 --- a/www/manager6/dc/AuthEditLDAP.js +++ b/www/manager6/dc/AuthEditLDAP.js @@ -139,6 +139,11 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', { PVE.Utils.delete_if_default(values, 'sync-defaults-options'); PVE.Utils.delete_if_default(values, 'sync_attributes'); + // Force values.delete to be an array + if (typeof values.delete === 'string') { + values.delete = values.delete.split(','); + } + if (me.isCreate) { delete values.delete; // on create we cannot delete values } -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel