Am 15/03/2023 um 10:54 schrieb Dominik Csapak: > hi, > > so high level comment: > i'd write most of what you wrote in the cover letter here in the commit > message, > makes it much more convenient to find it only via git ;) > > also i'm missing a bit the rationale for how the regex was chosen, besides > that it works in some conditions > > further comment inline > > On 1/31/23 13:50, Christoph Heiss wrote: >> Signed-off-by: Christoph Heiss <[email protected]> >> --- >> src/PVE/Auth/LDAP.pm | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >>
applied, with Dominiks R-b/T-b and more info and references added to the commit message, thanks! _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
