v1->v2: * actually added the /etc/hosts from an alpine template (seems I fat-fingered a cp iniially) for patch 2 - sorry for the fuzz
original cover-letter for v1: the patch from: https://lists.proxmox.com/pipermail/pve-devel/2023-June/057420.html broke the setup for templates which don't contain /etc/hosts. This was fixed in a follow-up by Thomas. Sorry for not noticing the broken tests (they are currently skipped if building with sbuild, which I used)! patch 2 adds an explicit test for the functionality in the patch While checking the output I noticed a small glitch with Test::MockModule in the snapshot-test.pm - which should be addressed with patch 1 of this series. Stoiko Ivanov (2): tests: fix small syntax glitch tests: add minimal test for LXC_NAME hosts entry src/test/snapshot-test.pm | 12 +++++------ src/test/test-alpine-003/config | 2 ++ src/test/test-alpine-003/etc/alpine-release | 1 + src/test/test-alpine-003/etc/hostname.exp | 1 + src/test/test-alpine-003/etc/hosts | 3 +++ src/test/test-alpine-003/etc/hosts.exp | 5 +++++ .../test-alpine-003/etc/network/interfaces | 0 src/test/test-alpine-003/etc/passwd | 21 +++++++++++++++++++ .../roothome/.ssh/authorized_keys.exp | 3 +++ 9 files changed, 42 insertions(+), 6 deletions(-) create mode 100644 src/test/test-alpine-003/config create mode 100644 src/test/test-alpine-003/etc/alpine-release create mode 100644 src/test/test-alpine-003/etc/hostname.exp create mode 100644 src/test/test-alpine-003/etc/hosts create mode 100644 src/test/test-alpine-003/etc/hosts.exp create mode 100644 src/test/test-alpine-003/etc/network/interfaces create mode 100644 src/test/test-alpine-003/etc/passwd create mode 100644 src/test/test-alpine-003/roothome/.ssh/authorized_keys.exp -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel