The checkbox is enabled by default, setting the new `check-connection`
parameter. See also [0] for the rationale.

[0] https://lists.proxmox.com/pipermail/pve-devel/2023-July/058559.html

Signed-off-by: Christoph Heiss <c.he...@proxmox.com>
---
N.B.: As this uses the newly introduced `check-connection` API
parameter, a bump on libpve-access-control is needed.

Changes v2 -> v3:
  * No changes

Changes v1 -> v2:
  * Add "Check connection" checkbox to AD edit too

 www/manager6/dc/AuthEditAD.js   | 15 +++++++++++++++
 www/manager6/dc/AuthEditLDAP.js | 15 +++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/www/manager6/dc/AuthEditAD.js b/www/manager6/dc/AuthEditAD.js
index a1999cb74..3cbb47c9f 100644
--- a/www/manager6/dc/AuthEditAD.js
+++ b/www/manager6/dc/AuthEditAD.js
@@ -79,6 +79,21 @@ Ext.define('PVE.panel.ADInputPanel', {
            },
        ];

+       me.advancedItems = [
+           {
+               xtype: 'proxmoxcheckbox',
+               fieldLabel: gettext('Check connection'),
+               name: 'check-connection',
+               uncheckedValue: 0,
+               checked: true,
+               autoEl: {
+                   tag: 'div',
+                   'data-qtip':
+                       gettext('Verify connection parameters and bind 
credentials on save'),
+               },
+           },
+       ];
+
        me.callParent();
     },
     onGetValues: function(values) {
diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js
index 2ce16e58c..9986db8a9 100644
--- a/www/manager6/dc/AuthEditLDAP.js
+++ b/www/manager6/dc/AuthEditLDAP.js
@@ -79,6 +79,21 @@ Ext.define('PVE.panel.LDAPInputPanel', {
            },
        ];

+       me.advancedItems = [
+           {
+               xtype: 'proxmoxcheckbox',
+               fieldLabel: gettext('Check connection'),
+               name: 'check-connection',
+               uncheckedValue: 0,
+               checked: true,
+               autoEl: {
+                   tag: 'div',
+                   'data-qtip':
+                       gettext('Verify connection parameters and bind 
credentials on save'),
+               },
+           },
+       ];
+
        me.callParent();
     },
     onGetValues: function(values) {
--
2.41.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to