Am 21/11/2023 um 09:54 schrieb DERUMIER, Alexandre: >> >>>> For the code it would be nice to add a helper that asserts that >>>> frr >>>> is installed >>>> for all API endpoints that need it, that way user get informed >>>> upfront, similar >>>> to how we do it for ceph (but no full web installer for now ^^) >> >> Yes good idea. >> >> I don't known if it's easy to check, as the frr is local to each >> node, >> and the sdn api is global at datacenter level. ? > >>> hmm true, one would only see if the current node one is connect >>> through supports it, a warning (or error) on apply could be better >>> then, should ideally happen as early as possible though, to not roll >>> out a partial state. > > I think that we could broadcast the state of the service with pvestatd, > > like for ceph services ? >
Yes, but IMO it'd be better to rework that into a more general mechanism that allows to check if a feature is supported supported. We could also hook into apt/dpkg there and only update this state on actual changes to the installed packages. But IMO something for the future, for now warning on apply is fine enough IMO, if we switch those warnings to using PVE::RESTEnvironment::log_warn the task will also be marked orange in the UI task list, so it would be quite visible for the admin. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
