Tested it using Windows Server 2022 and Samba 4.19.2 on Linux, with both LDAP and AD realms.
Fixes the problem after a re-sync, LGTM. Tested-by: Christoph Heiss <c.he...@proxmox.com> On Wed, Dec 20, 2023 at 03:37:03PM +0100, Filip Schauer wrote: > Decode non-ASCII character when syncing user attributes, since those > will be encoded later on. Without this fix the attributes where encoded > twice, resulting in cases such as 'ü' turning into 'ü'. > > Signed-off-by: Filip Schauer <f.scha...@proxmox.com> > --- > src/PVE/Auth/LDAP.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm > index b958f2b..5e7a30c 100755 > --- a/src/PVE/Auth/LDAP.pm > +++ b/src/PVE/Auth/LDAP.pm > @@ -301,7 +301,7 @@ sub get_users { > > foreach my $attr (keys %$user_attributes) { > if (my $ours = $ldap_attribute_map->{$attr}) { > - $ret->{$username}->{$ours} = $user_attributes->{$attr}->[0]; > + $ret->{$username}->{$ours} = > PVE::Tools::decode_text($user_attributes->{$attr}->[0]); > } > } > > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel