Am 13.02.24 um 12:52 schrieb Markus Frank: > Thanks, > > I already moved most of the code into a new PVE/QemuServer/Virtiofs.pm > module. >
Great! :) > Just an clarification & question concerning the queue-size: > > On 2024-01-31 16:02, Fiona Ebner wrote: >>> + push @$devices, '-chardev', >>> "socket,id=virtfs$i,path=/var/run/virtiofsd/vm$vmid-fs$i"; >>> + push @$devices, '-device', 'vhost-user-fs-pci,queue-size=1024' >> >> Any specific reason for queue-size=1024? Better performance than the >> default 128? > > There was problem with Windows Guests: > https://bugzilla.redhat.com/show_bug.cgi?id=1873088 > https://github.com/virtio-win/kvm-guest-drivers-windows/issues/764 > > queue-size=1024 is still in every documentation and every qemu command > for virtiofs I have seen used 1024. Good to know! Please add a comment referencing this, so people looking at the code will be aware of it and why the value was chosen. > Would it better to add a parameter to configure this queue-size? We can add a parameter if enough users with valid use cases request it. But to start out, I don't see much need for it. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
