with a few small follow-ups in pve-manager On April 2, 2024 4:55 pm, Max Carrara wrote: > Fix #4759: Configure Permissions for ceph-crash.service - Version 5 > =================================================================== > > Notable changes since v4 > ------------------------ > > * The patches regarding Ceph Reef and Ceph Quincy have been applied in > v4 and are thus dropped from this series (thanks Thomas!) > * The tests for both the parser and the writer are rewritten, making > them independent of one another > * Many additional test cases > * New test subroutine that compares each test case against Ceph's > `ceph-conf` CLI in order to preemptively detect changes / regressions > in Ceph's config file format > - In total, there are now 37 test cases, each tested against 3 > testing subroutines, making 111 tests in total > * The Ceph config writer now correctly escapes all un-escaped comment > literals > * The Ceph config parser is completely rewritten, making its > implementation almost fully equivalent to Ceph's original parser > * Suppress warning messages while running `postinst` of 'pve-manager' > (thanks Friedrich!) > * Prevent `deb-systemd-invoke` from failing (thanks Fabian!) > > For a detailed list of changes, please see the comments in the in the > individual patches. > > Post-Installation Version Guard > ------------------------------- > > The call to the new function in the `postinst` hook, which is introduced > in patch 09, now uses '0.0.0' as placeholder in its version guard. > > When applying this series, this placeholder must be replaced with the > next expected version of the 'pve-manager' package in order to run the > Ceph configuration helper during users' next update (patches 09, 10). > > Older Versions > -------------- > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061546.html > v2: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061646.html > v3: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061802.html > v4: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062093.html > > Summary of Changes > ------------------ > > pve-storage: > > Max Carrara (8): > cephconfig: change code style inside config writer > test: add tests for 'ceph.conf' parser and writer > test: cephconfig: add regression test for Ceph config parser & writer > cephconfig: allow writing arbitrary sections > cephconfig: change order of written sections > cephconfig: align written key-value pairs by tab > cephconfig: escape un-escaped comment literals on write > cephconfig: align our parser with Ceph's parser > > debian/control | 1 + > src/Makefile | 1 + > src/PVE/CephConfig.pm | 282 +++++- > src/PVE/Makefile | 4 + > src/PVE/test/Makefile | 9 + > src/PVE/test/ceph_conf_parse_write_test.pl | 1035 ++++++++++++++++++++ > 6 files changed, 1305 insertions(+), 27 deletions(-) > create mode 100644 src/PVE/test/Makefile > create mode 100755 src/PVE/test/ceph_conf_parse_write_test.pl > > > pve-manager: > > Max Carrara (3): > ceph: introduce '/etc/pve/ceph' > fix #4759: ceph: configure ceph-crash.service and its key > bin/make: gather helper scripts in separate variable > > PVE/API2/Ceph.pm | 5 ++ > PVE/API2/Ceph/MON.pm | 8 +++ > PVE/Ceph/Tools.pm | 47 ++++++++++++- > bin/Makefile | 6 +- > bin/pve-init-ceph-crash | 142 ++++++++++++++++++++++++++++++++++++++++ > debian/postinst | 25 +++++++ > 6 files changed, 230 insertions(+), 3 deletions(-) > create mode 100755 bin/pve-init-ceph-crash > > -- > 2.39.2 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > >
_______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel