Am 18/04/2024 um 10:03 schrieb Stefan Sterz: >> + before, and during the upgrade of a Proxmox VE system.\n" >> $@.tmp > > i know this is pre-existing, but since you are touching this anyway: the > comma here is odd, if this was supposed to be an oxford comma (or serial > comma), please be aware that these only apply in lists of three or more > items. here we have two lists of two items, so the oxford comma does not > apply.
yeah, that can be dropped – I often tend to go for the comma if I'm in doubt, in a hurry, or the like... ^^ > >> + printf "Any failures or warnings must be addressed prior to the >> upgrade.\n" >> $@.tmp >> + printf "If you think that a message is a false-positive, check this >> carefully before proceeding.\n" >> $@.tmp > > again a matter of personal taste, but "check this carefully" sounds a > bit clumsy to me. maybe "double-check that the tool is incorrect before > proceeding". I'd not suggest the tool being incorrect, rather that one should ensure that the warning does not apply to one's setup. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
