ok after a bit of thinking and discussing off-list
the plan to go forward from my side is this:
(please tell if there is something obviously wrong with it or you'd
strongly prefer something differently)
extract on demand vs on upload:
i'd go with extract on demand because managing the extraction of the tarball + subdir etc is not
really a win in my book, since we have to have most safeguards anyway and we have the same
issue of where to store/map it etc. also it's not convenient for users that
have already
a bunch of ovas and want to store them in a central place, now they'd have to
extract
them just for us (and importing should be as small a hassle as it can be)
for placing the extract code, i'd strongly prefer the (future) PVE::GuestImport namespace in
pve-storage, as that does not pollute the plugin api with irrelevant stuff and is relatively
far away from qemu-server (so we could reuse it later for other things if we
need to)
as for the extraction/cleanup step:
i'll reuse the 'images' part of the storage to extract it there with a valid vm
disk name.
that way if the cleanup fails, it can be deleted from the ui at least
if the storage does not have an images content type or the user does not have
the relevant
privileges, i'd force the user to provide (with a new parameter for creating) a
file based
storage with content type images. that can be shown in the gui only for ova
imports.
(and would default to the import storage if possible)
i think that were all the "big" questions for this series, please do tell if i
forgot something ;)
if no one objects to these things (or has even better ideas to solve some of
these),
i'd get started on that ASAP
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
