I am not sure how often we actually need that information as it can add quite a bit of additional lines in the report in larger machines with many memory slots.

It might be better to keep that command in a cheatsheet to ask for it if actually needed instead of polluting the report :)

On  2024-04-18  11:16, Alexander Zeidler wrote:
* to see if a RAM upgrade is slot/capacity-wise possible
* to spot added/replaced RAM that may now be causing issues

        Maximum Capacity: 2 TB
        Size: 16 GB     Part Number: 18ASF2G72PZ-2G6D1
        Size: 16 GB     Part Number: 18ASF2G72PZ-2G6D1
        Size: 16 GB     Part Number: 18ASF2G72PZ-2G6D1
        Size: 16 GB     Part Number: 18ASF2G72PZ-2G6D1
        Size: No Module Installed
        Size: No Module Installed
        Size: No Module Installed
        Size: No Module Installed

Signed-off-by: Alexander Zeidler <a.zeid...@proxmox.com>
---
v2:
* make regex stricter
* reduce possible dmidecode output which is not needed here
* reduce and clarify the printed information

v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062348.html


  PVE/Report.pm | 1 +
  1 file changed, 1 insertion(+)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index 9d1b9b27..d9f81a0f 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -113,6 +113,7 @@ my $init_report_cmds = sub {
                'cd /sys/devices/virtual/dmi/id; grep -HT "" sys_vendor 
product_name product_version',
                'cd /sys/devices/virtual/dmi/id; grep -HT "" board_vendor 
board_name board_version',
                'dmidecode -t 0,3,32',
+               'dmidecode -t16,17 | grep -P "^\t(Max[^:]*city|Size|Part)" | sed -Ez 
"s/\n(\tP[^\n]*)/\1/g" | sort',
                'lspci -nnk',
            ],
        },


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to