Am 13.06.24 um 12:39 schrieb Dominik Csapak: > On 6/12/24 18:02, Max Carrara wrote: >> On Fri May 24, 2024 at 3:22 PM CEST, Dominik Csapak wrote: >>> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> >>> --- >>> www/manager6/window/GuestImport.js | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/www/manager6/window/GuestImport.js >>> b/www/manager6/window/GuestImport.js >>> index 4bedc211..76ba6dc8 100644 >>> --- a/www/manager6/window/GuestImport.js >>> +++ b/www/manager6/window/GuestImport.js >>> @@ -937,6 +937,7 @@ Ext.define('PVE.window.GuestImport', { >>> gettext('EFI state cannot be imported, you may need to >>> reconfigure the boot order (see {0})'), >>> '<a >>> href="https://pve.proxmox.com/wiki/OVMF/UEFI_Boot_Entries">OVMF/UEFI >>> Boot Entries</a>', >>> ), >>> + 'ova-needs-extracting': gettext('Importing from an OVA >>> requires extra space while extracting the contained disks into the >>> import or selected storage.'), >> >> I'm assuming the string here needs to be in one line because of >> `gettext`, right? If not, I'd prefer to break it up ;) > > yes, AFAIK we the gettext parsing script does not handle multiline calls > at the moment > we could probably check if there is a javascript syntax parsing library > available > in perl, or rewrite the script in some other language where such a thing > exists, > then it wouldn't be so brittle probably > > but it's not generally such a big issue that we would need to worry > about it
FYI, there's also the proposal from Maximiliano to use xgettext: https://lists.proxmox.com/pipermail/pve-devel/2023-December/060970.html _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel