Superseeded by v3: https://lore.proxmox.com/pve-devel/20250617153145.18048-1-s.sh...@proxmox.com/T/#u
On Fri Jun 13, 2025 at 2:29 PM CEST, Michael Köppl wrote: > Tested the effects of the changes on Android, so I cannot say anything > about the effects on iOS. With the exception noted below, I did not > notice any problems in the UI, neither in portrait mode nor in landscape > mode. I compared the visual changes in all affected widgets. > > I left 2 comments inline. > > On 6/12/25 10:57, Shan Shaji wrote: > > In iOS, there was a blue background color visible beneath the bottom > > bar, which caused the app to not utilize the full screen height. > > Additionally, the colors of the app bar and the status bar > > differed when the user began scrolling. > > > > This issue was due to the container color used in the `ColoredSafeArea` > > widget, which wrapped the `SafeArea` widget. To fix the issue, > > remove the `ColoredSafeArea` and its usages, as all affected screens > > already include an `AppBar` widget. Therefore, using a separate > > `SafeArea` is not necessary. > > > > Also skips running the `dart format` command as there are > > formatting changes in the changed files and will be hard to > > identify the changes if the files are formatted. > > Please also consider rewriting the commit message to focus on stating > the semantic change of the commit. Paragraphs like this one about `dart > format` should go under ---. > > > > > Additionaly since the `SafeArea` inside the resource tab and the > > task log page is removed as a result the filter sheet was interferring > > with the status bar in Android and notch in iOS. To fix the > > issue, wrap the drawer content in `SafeArea`. > > This seems to affect the two widgets differently. While the > "interference" with the status bar is fixed in both cases, the filter > sheet in the task log widget now goes all the way to the top of the > screen (hiding part of the app bar below it), whereas the filter sheet > in the resources tab still begins just under the app bar. While I do > prefer the sheet that goes above the app bar personally (very > subjective, of course), I'd consider consistency the most important > aspect. Maybe someone else can chime in regarding their preferred > option, but whichever ends up being used, it should be applied to *all* > filter sheets. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
