https://lore.proxmox.com/pve-devel/20250729171649.708219-1-s.hanre...@proxmox.com/T/#t
On 7/24/25 4:49 PM, Stefan Hanreich wrote: > This patch series lifts the restriction for naming physical interfaces. > Previously we relied on a regex (PHYSICAL_NIC_RE) for determining whether an > interface was physical or not. This patch series changes that, by querying the > kernel for the type of the interface and using that to determine whether an > interface is a physical interface or not. This allows us to use arbitrary > names > for physical interfaces, which in turn allows > proxmox-network-interface-pinning > to use arbitrary prefixes / target-names when pinning network interfaces. > > The main change here is with pvestatd and metric collection, where we used the > regex to determine the type of interface in PullMetric. I introduced a new key > in the netdev hash that indicates the type of interface. Since my knowledge of > this component is almost zero, I'm not sure if this is the proper approach. > Maybe someone with more experience can chime in on possible issues / > improvements. > > This patch series applies on top of my previous series that improves several > aspects of the pinning tool [1]. > > pve-manager depends on pve-common > > [1] > https://lore.proxmox.com/pve-devel/20250724093459.76397-1-s.hanre...@proxmox.com/T/#t > > pve-common: > > Stefan Hanreich (1): > inotify/interfaces: use ip link for detecting physical interfaces > > src/PVE/INotify.pm | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > > pve-manager: > > Stefan Hanreich (2): > pvestatd: pull metric: use ip link to detect physical interfaces > network-interface-pinning: allow arbitrary names > > PVE/CLI/proxmox_network_interface_pinning.pm | 7 ++++--- > PVE/PullMetric.pm | 15 ++++++++++++--- > PVE/Service/pvestatd.pm | 13 ++++++++++++- > 3 files changed, 28 insertions(+), 7 deletions(-) > > > Summary over all repositories: > 4 files changed, 41 insertions(+), 19 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel