Am 08.09.25 um 10:07 PM schrieb Andrei Perapiolkin:
> I have added a bug report: https://bugzilla.proxmox.com/show_bug.cgi?
> id=6776
Thanks!
> I also decided to return an empty string ('') for volumes that do not
> exist.
>
> My reasoning is that if I return any path that might actually exist,
> some parts of the Proxmox system could try to open, read, or write to
> this "file," unintentionally creating it.
> This could corrupt the server’s file system, or consume disk space if
> the server has limited local storage — for example, when the operation
> involves cloning a multi-terabyte data block.
>
> I would like to hear your opinion regarding this conclusion.
> Is it acceptable, or should I re-evaluate it?
I don't think an image would be auto-created, except if the storage or
filesystem is doing that upon open, which would be wrong. The path is
just passed along to QEMU (or qemu-img) and those will abort if it
cannot be opened.
With returning '' you might run into other errors or warnings and since
other plugins don't do this, it's not really tested. You would be more
in line with other plugins by returning the path. Alternatively, using
"die" if the volume doesn't exist, seems a bit nicer too and would be in
line with what the related qemu_blockdev_options() method does.
Best Regards,
Fiona
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
