The remove_left_over_vmstate_opts() function might write the
configuration, so it cannot be called in the context of a migration,
where the configuration file will be moved over from the source node
later. As reported in the enterprise support, this could cause an
error like:
> close (rename) atomic file '/etc/pve/nodes/XYZ/qemu-server/211.conf' failed:
> File exists
Fixes: 0db14e60 ("vm start: remove left-over VM-state-related properties")
Signed-off-by: Fiona Ebner <[email protected]>
---
src/PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 69991843..53001b9b 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -5956,7 +5956,7 @@ sub vm_start_nolock {
}
delete $conf->@{qw(lock vmstate running-nets-host-mtu runningmachine
runningcpu)};
PVE::QemuConfig->write_config($vmid, $conf);
- } elsif (!$conf->{vmstate}) {
+ } elsif (!$conf->{vmstate} && !$migratedfrom) {
remove_left_over_vmstate_opts($vmid, $conf);
}
--
2.47.3
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
