Maximiliano Sandoval <[email protected]> writes:
> ..and add more logging when issuing fsfreeze guest commands.
>
> The new setting takes precedence over freeze-fs-on-backup and deprecates the
> former.
>
> - At the moment taking a snapshot without RAM does not log whether there was a
> freeze/thaw, we add logs when issuing freezes/thaws.
>
> - The patch does not result in an extra log line when making a Backup in
> snapshot mode.
>
> - When it is easy to do so, we log if the fsfreeze command was not issued due
> to
> mismatch between the agent running and the config, e.g. when say that we
> skipped it if the agent is enabled bu the configuration says we shouldn't.
@fiona, one thing I just noticed is that `import_from_volid` calls
clone_disk() with $src_config->{'agent'} as an argument.
- Is this OK as-is, or should it also take into account the new
guest-fsfreeze setting?
- What operations would trigger this codepath?
--
Maximiliano
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
