On Wed Jan 14, 2026 at 4:57 PM CST, Thomas Lamprecht wrote:
> On Wed, 07 Jan 2026 18:41:46 +0800, Kefu Chai wrote:
>> A regression was introduced in PR #62174 that added a `ceph_assert()`
>> statement which incorrectly assumes alloc_unit is always aligned. This
>> causes OSD crashes when the assertion fails.
>> 
>> This cherry-pick removes the faulty assertion, resolving the crash while
>> maintaining correct functionality for both aligned and unaligned alloc_unit
>> values.
>> 
>> [...]
>
> Applied, but ammended the commit to actually add the patch to the quilt series
> file, so that it's picked up by the debian build system and fixed the -22 
> lines
> offset of the diff hunk, thanks!

Thank you for taking care of this. Will double check the patches before
sending them out next time.

>
> btw. as the final reef release 18.2.8 is being planned (again), and should be
> ready soon after the ceph lab is up again after their DC move, do you think
> this should be released earlier or could it be fine to wait a bit.

Regarding the v18.2.8 release timeline: according to Patrick's email,
we're restarting QA for this final Reef release. It might take a couple
weeks to complete the QA process.

However, I'm concerned about the flapping OSD issue caused by the assert
failure -- it's a significant problem that we can't ignore. Given this,
do you think we should prioritize an earlier release to address it?

>
> FWIW, we could upload just the ceph-osd packages for now, or are there other
> daemons affected by this fix?

Yes, the only artifacts / executables using BlueFS are, ceph-osd, 
ceph-bluestore-tool, ceph-objectstore-tool and ceph_objectstpre_bench.
All of them are currently provided by ceph-osd package. So it'd suffice
to upload the ceph-osd package for this hotfix.

>
> [1/1] bluefs: fix OSD crash caused by incorrect alignment assertion
>       commit: 59bb899d8398575768b6ddd9dc7f4eabd0018533



_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to