Hi Wolfgang, could you please help review this change? It's not a critical one, but it helps to address the warning from the compiler.
On Mon Jan 5, 2026 at 10:05 PM CST, Kefu Chai wrote: > Root cause: > The cc crate deprecated the shared_flag() method because it only > creates static libraries (.a files), making the shared_flag parameter > meaningless and confusing. > > The warning indicated: > warning: use of deprecated method `cc::Build::shared_flag`: > cc only creates static libraries, setting this does nothing > > Impact: > - shared_flag(false) was a no-op that did nothing > - Its removal does not change the build behavior > - The build still produces libglue.a as expected > > Fix: > Remove the .shared_flag(false) call from the cc::Build chain. > The build defaults to static library output, which is what we want. > > Verification: > - Build completes without warnings > - Generated library is still static (.a) > - No functional changes to the FUSE bindings > > Signed-off-by: Kefu Chai <[email protected]> > --- > build.rs | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/build.rs b/build.rs > index d75166e..f9dd5f1 100644 > --- a/build.rs > +++ b/build.rs > @@ -11,10 +11,7 @@ fn main() { > > let mut cc = cc::Build::new(); > > - cc.pic(true) > - .shared_flag(false) > - .opt_level(3) > - .flag("-DFUSE_USE_VERSION=35"); > + cc.pic(true).opt_level(3).flag("-DFUSE_USE_VERSION=35"); > > for flag in ccflags.split_ascii_whitespace() { > cc.flag(flag); _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
