Generate the interfaces that have been configured with IS-IS to the ifupdown config (enable ip-forwarding on all). IS-IS needs to have the ip-address duplicated from the dummy interface to every interface in unnumbered mode (like with ospf). This could potentially be fixed in the future with [0].
[0]: https://github.com/FRRouting/frr/pull/19429 Signed-off-by: Gabriel Goller <[email protected]> --- pve-rs/src/bindings/sdn/fabrics.rs | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs index 18848c405201..c4150c830a0a 100644 --- a/pve-rs/src/bindings/sdn/fabrics.rs +++ b/pve-rs/src/bindings/sdn/fabrics.rs @@ -354,6 +354,13 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties_mut().interfaces_mut() { + if let Some(mapped_name) = map_name(&mapping, interface.name())? { + interface.set_name(mapped_name); + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties_mut().interfaces_mut() { if let Some(mapped_name) = map_name(&mapping, interface.name())? { @@ -453,6 +460,9 @@ pub mod pve_rs_sdn_fabrics { FabricEntry::Openfabric(_) => { daemons.insert("fabricd"); } + FabricEntry::Isis(_) => { + daemons.insert("isisd"); + } }; } @@ -547,6 +557,40 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties().interfaces() { + if let Some(ip) = interface.ip() { + let interface = + render_interface(interface.name(), Cidr::from(ip), false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + if let Some(ip) = interface.ip6() { + let interface = + render_interface(interface.name(), Cidr::from(ip), false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + + // If no ip is configured, add auto and iface with node ip to bring + // interface up ISIS doesn't really need an ip on the interface, but the + // problem is that arp can't tell which source address to use in some + // cases, so it's better if we set the node address on all the fabric + // interfaces. + if let (None, None) = (interface.ip(), interface.ip6()) { + let cidr = Cidr::from(if let Some(ip) = node.ip() { + IpAddr::from(ip) + } else if let Some(ip) = node.ip6() { + IpAddr::from(ip) + } else { + anyhow::bail!("there has to be a ipv4 or ipv6 node address"); + }); + let interface = render_interface(interface.name(), cidr, false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties().interfaces() { if let Some(ip) = interface.ip() { -- 2.47.3
