For remote migration, we already check that the config can be parsed on the target. Do the same for intra-cluster migration, to avoid issues like [0] for future new settings, with lines being unexpectedly and relatively silently dropped (there are warnings in the target's system logs).
The first few patches are cleanups/tiny improvements that would be nice to have in any case. Unfortunately, before patch "qm: mtunnel: reply when a command is unknown", when a command is unknown, mtunnel did not reply at all. Therefore, this delays backwards migrations to qemu-server versions less than the next bumped version (at the time of this writing expected to be 9.1.5) by 3 seconds. I opted for 3 seconds, since config parsing should be very quick and 5 seconds would still be very noticeable for a bulk migration of VMs on a shared storage with a fast network. Right now, the option won't help anyways, only once we add a new config option (at which point we could bump it to 5 seconds). [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=7341 qemu-server: Fiona Ebner (6): d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 tests: migration: get rid of mocking for removed PVE::QemuMigrate::read_tunnel() qm: mtunnel: avoid using deprecated check_running() helper mtunnel: add 'conf' command to do strict configuration parsing qm: mtunnel: reply when a command is unknown migration: intra-cluster: check config can be parsed on target node debian/control | 2 +- src/PVE/API2/Qemu.pm | 4 +++- src/PVE/CLI/qm.pm | 21 ++++++++++++++++++--- src/PVE/QemuMigrate.pm | 23 +++++++++++++++++++++++ src/test/MigrationTest/QemuMigrateMock.pm | 14 ++++++++++---- 5 files changed, 55 insertions(+), 9 deletions(-) Summary over all repositories: 5 files changed, 55 insertions(+), 9 deletions(-) -- Generated by git-murpp 0.5.0
