Thanks for the quick iteration on this! For reference: These 2 patches replace PATCH 4/4 from: https://lore.proxmox.com/pve-devel/[email protected]/
The idea being that patch 1/2 is applied first - then the patches for pve-container, pve-manager, pmg-api, with a versioned dependency bump on libpve-common-perl. Once this is rolled PATCH 2/2 from this series can be applied as well (breaking pve-container, pve-manager, pmg-api not containing the patches from the v2). 3 tiny nits, which are mostly for any future patches - the complete series is fine as is IMO. nit: I'd use different first line for the commit message of each patch e.g.: 1/2: fix #7175: add timezonectl helpers to PVE::Systemd 2/2: fix #7175: drop deprecated /etc/timezone file helpers this can be fixed up on applying. nit: sending the complete series again (even if patches for the other repositories did not change at all) helps in having all needed things in one thread - the duplicate mails are less of a problem. nit: it seems you set my e-mail as reply-to header for this series (this should not be an issue, as most people hit "Reply All" in their mail-clients anyway, but could cause some confusion) - maybe you wanted to add me in CC (`--cc [email protected]` for git send-email)? As the 2 patches together here amount to the same result as the patch for pve-common in the v2 - my: Reviewed-by: Stoiko Ivanov <[email protected]> Tested-by: Stoiko Ivanov <[email protected]> still applies (and I quickly checked applying only patch 1/2 on a test-vm of mine) Thanks again for your work on this and making the effort to address the feedback - much appreciated! stoiko On Sun, 22 Feb 2026 12:02:03 +0100 Stefan Mayr <[email protected]> wrote: > This splits the patch to pve-common into two parts: > 1. adds functions for systemd timedatectl > 2. removes handling deprecated /etc/timezone from INotify module > > > >
