This was discussed off-list with Fiona. Something that was missing from Fiona's comments was giving the "hint" css class to the "Deprecated" part of the old checkbox's label. I was not sure how to make that work in extjs.
The migration would work as follows: - The new key takes preference over the old one so using the old one is OK. - If the key is in the config file then the old checkbox would dbe displayed - But delete the key from the config if the freeze is enabled, since it is the default One could additionally do some extra work where setting the new key will also set the old value, but for the sake of simplicity I think this is a good start. I added to my TODO list to add a migration check to the pve9to10 script. Maximiliano Sandoval (7): ui: utils: support guest-fsfreeze at render_qga_features ui: qga: merge translatable string ui: qga: move freeze-fs-on-backup to advanced opts ui: qga: note that freeze-fs-on-backup is deprecated ui: qga: add checkbox for guest-fsfreeze ui: qga: call parameter me instead of this ui: qga: hide freeze-fs-on-backup check if undefined www/manager6/Utils.js | 2 + www/manager6/form/AgentFeatureSelector.js | 62 ++++++++++++++++++++--- 2 files changed, 56 insertions(+), 8 deletions(-) -- 2.47.3
