On 27.02.2026 12:56, Stefan Hanreich wrote:
> On 2/3/26 5:01 PM, Gabriel Goller wrote:
> > [snip]
> > diff --git a/proxmox-frr-templates/templates/bgp_router.jinja
> > b/proxmox-frr-templates/templates/bgp_router.jinja
> > new file mode 100644
> > index 000000000000..6f48d6ca17a4
> > --- /dev/null
> > +++ b/proxmox-frr-templates/templates/bgp_router.jinja
> > @@ -0,0 +1,118 @@
> > +{% macro address_family_common(common_address_family) -%}
> > +{% for vrf in common_address_family.import_vrf %}
> > + import vrf {{ vrf }}
> > +{% endfor %}
> > +{% for neighbor in common_address_family.neighbors %}
> > + neighbor {{ neighbor.name }} activate
> > + {% if neighbor.soft_reconfiguration_inbound %}
> > + neighbor {{ neighbor.name }} soft-reconfiguration inbound
> > + {% endif %}
> > + {% if neighbor.route_map_in %}
> > + neighbor {{ neighbor.name }} route-map {{ neighbor.route_map_in }} in
> > + {% endif %}
> > + {% if neighbor.route_map_out %}
> > + neighbor {{ neighbor.name }} route-map {{ neighbor.route_map_out }} out
> > + {% endif %}
> > +{% endfor -%}
> > +{% for line in common_address_family.custom_frr_config %}
> > +{{ line }}
> > +{% endfor -%}
> > +{% endmacro -%}
> > +{% macro bgp_router(router_config) %}
> > + bgp router-id {{ router_config.router_id }}
> > + no bgp hard-administrative-reset
>
> this option should be exposed and not hardcoded
>
> > +{% if router_config.default_ipv4_unicast == false %}
> > + no bgp default ipv4-unicast
> > +{% endif %}
> > +{% if router_config.coalesce_time %}
> > + coalesce-time {{ router_config.coalesce_time }}
> > +{% endif %}
> > + no bgp graceful-restart notification
>
> here as well
Agree.
