>>this is the same: >>return if !$rate; >> >>$rate can be 0 or undef
Ok, got it. is it ok like this for you dietmar ? (return if !$rate) ----- Mail original ----- De: "Stefan Priebe - Profihost AG" <s.pri...@profihost.ag> À: pve-devel@pve.proxmox.com Envoyé: Mardi 5 Mars 2013 12:39:04 Objet: Re: [pve-devel] [PATCH 3/6] setup_tc_rate_limit : delete class and filter before update this is too complex + return if (!$rate || ($rate && $rate == 0)); this is the same: return if !$rate; $rate can be 0 or undef Stefan Am 05.03.2013 12:20, schrieb Alexandre DERUMIER: >>> This expression makes no sense to me? Maybe we just need >>> >>> return if !$rate; > > pve-manager can send rate=0 to api2, is it filtered somewhere ? > (just to be sure, in perl, is 0 != undef ? ) > ----- Mail original ----- > > De: "Dietmar Maurer" <diet...@proxmox.com> > À: "Alexandre Derumier" <aderum...@odiso.com>, pve-devel@pve.proxmox.com > Envoyé: Mardi 5 Mars 2013 11:52:23 > Objet: RE: [pve-devel] [PATCH 3/6] setup_tc_rate_limit : delete class and > filter before update > >> system("/sbin/tc qdisc del dev $iface root >/dev/null 2>&1"); >> >> + return if (!$rate || ($rate && $rate == 0)); > > This expression makes no sense to me? Maybe we just need > > return if !$rate; > _______________________________________________ > pve-devel mailing list > pve-devel@pve.proxmox.com > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel