AFAIK save will remove any used volume from 'unusedX', so you will not get that behavior anyway.
>>Did you test your patch (does it really generate an unused entry for used >>disks)? Yes, I have tested it, and it's generate an unused disk. Another possibily could be do disalow delete option when disk migrate, if the disk have snapshot. ----- Mail original ----- De: "Dietmar Maurer" <[email protected]> À: "Alexandre DERUMIER" <[email protected]> Cc: [email protected] Envoyé: Mardi 15 Avril 2014 07:08:40 Objet: RE: [pve-devel] [PATCH] move_disk : don't delete disk if used in a previous snasphot v2 > I wanted to do the same behaviour. > > > I think it's better to put it as unused, than simply remove it from > configuration, > and have a phantom disk on the storage. AFAIK save will remove any used volume from 'unusedX', so you will not get that behavior anyway. Did you test your patch (does it really generate an unused entry for used disks)? _______________________________________________ pve-devel mailing list [email protected] http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
