Am 03.06.2014 05:46, schrieb Dietmar Maurer: >>> Also, It seems quite easy to support multiple auth. The server just >>> needs to send all supported auth modes in >>> >>> ui/vnc.c method protocol_version() >>> >>> something like: >>> >>> } else { >>> VNC_DEBUG("Telling client we support auth %d\n", vs->auth); >>> vnc_write_u8(vs, 2); /* num auth */ >>> vnc_write_u8(vs, vs->auth); >>> vnc_write_u8(vs, VNC_AUTH_VNC); >>> vnc_read_when(vs, protocol_client_auth, 1); >>> vnc_flush(vs); >>> } >>> >>> requires further modifications in protocol_client_auth() ... >>> >> >> Might be possible do you want to hardcode mode VNC_AUTH_VNC as a second >> mode? So the first is configurable and the second hardcoded? > > Yes, I thought about that - it is done the same way with vencrypt subauth. >
OK - but which advantage do we get beside we need to care about another patch while upgrading qemu versions? I mean we have to execute a monitor command anyway to set a password - what is the advantage of this qemu hack? Stefan _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel