>>Form what I see this case is already handled inside
>>storage_support_snapshop()?
PVE::Storage::volume_snapshot($storecfg, $volid, $snap) if
storage_support_snapshop($volid, $storecfg);
return if !$running;
vm_mon_cmd($vmid, "snapshot-drive", device => $deviceid, name => $snap);
and
storage_support_snapshop {
...
if ($volid =~ m/\.(qcow2|qed)$/){
+ $ret = 1;
+ }
So, with this code, we always call qemu-img snasphot for qcow2, which is wrong
if the vm is running.
(for rbd,zfs,.. no problem).
I think that's why we passed the running flag to pve-storage.
----- Mail original -----
De: "dietmar" <diet...@proxmox.com>
À: "aderumier" <aderum...@odiso.com>, "Wolfgang Link" <w.l...@proxmox.com>
Cc: "pve-devel" <pve-devel@pve.proxmox.com>
Envoyé: Jeudi 30 Avril 2015 12:28:36
Objet: Re: [pve-devel] [PATCH] remove running from Storage and check it in
QemuServer
> + PVE::Storage::volume_snapshot($storecfg, $volid, $snap) if
> storage_support_snapshop($volid, $storecfg);
>
> This seem to be wrong.
>
> we can't do a qcow2 snapshot with qemu-img if the vm is running, we need to
> use qmp in this case.
Form what I see this case is already handled inside storage_support_snapshop()?
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
