could you split this into two (or more) parts? mixing cosmetic changes like variable renaming and style fixes with actual changes makes it hard to read (and is also bad for git blameability ;)) if the two issues are easily split into their own commits that might make sense as well
mhmm, well in this case this is not so easy, because i rewrote most of the sub
so if i want to split it in two patches, i have to either fix code which gets then shifted and unindented (making the second patch not smaller) or i have to reintroduce the bug in the rewrite and then fixing it...
it this really desireable? sadly even with --patience, git is not smart enough to see that the function is almost completely different _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
