> @@ -1538,6 +1553,16 @@ __PACKAGE__->register_method ({
>                  type => 'integer',
>                  minimum => 1
>              },
> +         sharedonly => {
> +             description => "Migrate only those guests with only shared 
> storage",
> +             optional => 1,
> +             type => 'boolean'
> +         },
> +         onlineonly => {
> +             description => "Migrate only those guests with only shared 
> storage",

description is wrong!

> +             optional => 1,
> +             type => 'boolean'
> +         },

I can imagine another scenario:

- Migrate only those guests which are offline

so it is maybe better to define some filter enum:

filter => {
    type => 'string-list'
    description => "Migrate only those guests which match the filter.",
    optional => 1,
    enum => ['running', 'stopped', 'shared'],
}

So you can select to migrate all stopped VMs on shared 
storage with "--filter 'stopped,shared'"

?? 

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to