>>do you plan to update the documentation as well ? >>if you click the online help, we say online migration is not possible if >>you have disks on local storage which quite contradicts the feature
Sure I'll try to update documentation for tomorrow >>two minor nitpicks: I'll fix them and resend a patch tomorrow ----- Mail original ----- De: "e kasper" <e.kas...@proxmox.com> À: "pve-devel" <pve-devel@pve.proxmox.com> Envoyé: Lundi 3 Juillet 2017 16:44:51 Objet: Re: [pve-devel] [PATCH] add live storage migration to migrate window On 07/02/2017 08:30 AM, Alexandre Derumier wrote: > If online is checked && vm is a qemu machine, > > we display 2 new field: > > -use-local-disk checkbox (unchecked by default) > -target storage option (disabled by default, enabled is localdisk is checked) do you plan to update the documentation as well ? if you click the online help, we say online migration is not possible if you have disks on local storage which quite contradicts the feature two minor nitpicks: * we were not very good at that historically, but there is some indenting mismatch in lines 66-69 and 83-88 (spaces were tabs should be there) + allowBlank: true, + emptyText: gettext('Same as source'), + disabled: true, + hidden: running ? false : true, + }); * a bit pedantic but jslint complains about the trailing coma after 'true', _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel