On 08/23/2017 05:30 PM, Philip Abernethy wrote:
Disables the quota checkbox for unprivileged containers in the creation wizard,
as well as when editing or adding mountpoints.
---
With the editor windows I got confused by the caps.vms['Config.VM.Disk']
earlier, but that's access control. Removed the distinction altogether.
Recarding the commas I'd argue that readability ranks higher than short
patches.
I think we can all agree that this:
confid: 'rootfs'
,
unprivileged: false
looks horrible, doesn't help readability and only lengthens the file
unnecessarily. If you meant something else you'll need to clarify.
Yes, the changed line just for the comma is annoying, but I think the
alternative is even worse.
You creatively misinterpreted my, granted ambiguous, suggestion.
<http://www.dict.cc/englisch-deutsch/ambiguous.html>
www/manager6/lxc/CreateWizard.js | 20 +++++++++++++++-----
www/manager6/lxc/ResourceEdit.js | 10 ++++++++--
www/manager6/lxc/Resources.js | 7 ++++++-
3 files changed, 29 insertions(+), 8 deletions(-)
diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index c2f16a1a..a8f6ef9f 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -60,7 +60,8 @@ Ext.define('PVE.lxc.CreateWizard', {
insideWizard: true,
isCreate: true,
unused: false,
- confid: 'rootfs'
+ confid: 'rootfs',
+ unprivileged: false
To ensure nothing is unclear, I meant:
[...]
unused: false,+ unprivileged: false, confid: 'rootfs'
[...]
});
var networkpanel = Ext.create('PVE.lxc.NetworkInputPanel', {
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
