On 09/12/2017 02:30 PM, Wolfgang Bumiller wrote: > On Thu, Sep 07, 2017 at 10:00:07AM +0200, Emmanuel Kasper wrote: >> any feedback on this ? >> cancelling an action because it has been cancelled it not such an >> helpful error message ;) > > Wouldn't this result in: > drive-scsi0: Cancelling block job > 2017-07-31 17:51:44 ERROR: online migrate failure - mirroring error: > drive-scsi0: lost track of mirroring job (...) > > Doesn't look much better IMO? Isn't that more confusing?
Ordering is wrong indeed because we first cancel the block job, then die() with the real error but at least we have now a real informative message I will see if I can improve the ordering of output messages _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
