> Am 09.11.2017 um 15:03 schrieb Thomas Lamprecht <t.lampre...@proxmox.com>: > >> On 11/09/2017 02:09 PM, Caspar Smit wrote: >> If i look into the /etc/init.d/pveproxy script you will see that a >> 'restart' (and reload for that matter) does a: $DAEMON restart >> >> Where $DAEMON=/usr/bin/pveproxy >> >> So basically a "/etc/init.d/pveproxy restart (or reload)" should do a >> "/usr/bin/pveproxy restart" >> > > Yes, true, thanks for the correction. > >> Or is the init.d script skipped because the systemd wrapper picks it up as >> "systemctl restart pveproxy" ? (it looks that way:) >> > > Yeah, that's exactly the case, services files have always precedence and if > there is none, systemd auto generates one and passes the requested operation > (start, stop, restart) to this one, which changed the reload to a restart in > this case. So I'm swapped it out with reload in the patch I sent. > > cheers, Thomas
Works perfectly and applies cleanly to stable-4 branch. Thanks! Greets, Stefan > >> # /etc/init.d/pveproxy restart >> [ ok ] Restarting pveproxy (via systemctl): pveproxy.service. >> >> Kind regards, >> Caspar >> >> 2017-11-09 13:47 GMT+01:00 Thomas Lamprecht <t.lampre...@proxmox.com>: >> >>>> On 11/09/2017 01:40 PM, Stefan Priebe - Profihost AG wrote: >>>> *arg* sorry about that and thanks for resending your last paragraph. Yes >>>> that's exactly the point. >>>> >>>> Also thanks for the restart and systemctl explanation. >>>> >>> >>> I have also have to apologize me, we're both (partly) right: >>> log rotate configuration does a restart on the old init.d scripts not the >>> pveproxy executable itself (should got rid of those init.d scripts already) >>> which results really in a full stop/start cycle (as systemctl restart would >>> have been). >>> So yeah, it currently does the "wrong" restart, but even if it would do the >>> "correct" one the problem is still there as of aforementioned reason with >>> the graceful restart. So both have to get fixed, I look into it, thanks for >>> the report and your patience with this. >>> >>> cheers, Thomas >>> >>> _______________________________________________ >>> pve-devel mailing list >>> pve-devel@pve.proxmox.com >>> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >>> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@pve.proxmox.com >> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@pve.proxmox.com > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel