On 9/28/18 5:32 PM, Fabian Grünbichler wrote: > On Fri, Sep 28, 2018 at 03:38:03PM +0200, Thomas Lamprecht wrote: >> On 9/28/18 12:48 PM, Fabian Grünbichler wrote: >>> this series cleans up the packaging of our ha-manager repo: >>> - general improvements >>> - moving of common perl modules into own package instead of shipping them >>> twice in different paths >>> - cleanup of dependencies / use statements >>> (simulator now only requires libpve-common-perl and libpve-ha-common-perl) >>> - regular usage of dpkg-buildpackage >> >> much thanks for this! >> >> So for now I applied the low hanging easy fruits, i.e., >> 1, 2, 3, 4, 6 and 7. >> >> This should take a bit load of this not too small series. >> I'l have a close look at the rest and the meat of this series >> next week. > > great. an alternative approach instead of splitting the common parts out > into a common package would be to keep /usr/share/pve-ha-simulator as > PERLDIR and embed both the shared parts of pve-ha-manager and the used > modules from libpve-common-perl, thus making pve-ha-simulator completely > runtime-independent from any other PVE packages. a bit ugly IMHO, but > maybe closer to the original intent? >
Yes, it would fulfill the initial goal of making it independent. It was shipped now separately anyway - although it depended on libpve-common-perl and pve-cluster, the latter was by mistake, though. As, IMO, the simulator is more used on a non-pve workstation with an UI and Desktop userland, this could make sense. For the rare case that it's installed on a PVE node itself it'd be a few KB more than already installed, not ideal but not really bad either. For the user who goes the sane way, i.e. add us as repo and do # apt install pve-ha-simulator it doesn't really matter how it's split up anyway. _______________________________________________ pve-devel mailing list [email protected] https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
