On 1/3/19 11:54 AM, Wolfgang Bumiller wrote: > On Wed, Jan 02, 2019 at 02:54:04PM +0100, Dominik Csapak wrote: >> On 12/28/18 6:59 PM, Andreas Steinel wrote: >> 1. use our 'qemu version is greater than current' code, it then gets added >> with the next qemu update we will ship, and for migrated >> vms this will only get included after a stop/start of the vm > > I'd prefer to avoid this when it is not qemu-version dependent or > related. > > On Wed, Jan 02, 2019 at 07:47:33PM +0100, Andreas Steinel wrote: >> (...) >>> 2. add a new config option/property somewhere and add it by default in >>> the wizard in the gui, this makes it only the default by vms created there >> >> I think I'd want to have this, but I do not have any experience with >> programming in JS or extjs. >> I'm happy that I could integrate it into the perl code. >> >> I also created the audio patch so that it'll work with spice audio. I'd >> really want to have a new option >> like "Desktop integration", because this is only needed if you want a "near >> desktop experience" and >> not always, like it is now. >> >> I can try to rewrite my patch to do that. I'll have a look later this week. > > A separate option probably makes the most sense.
+1 We can help you with the GUI part if the backend one is done, as it shouldn't be to much work (knocks wood). > > On Wed, Jan 02, 2019 at 02:54:04PM +0100, Dominik Csapak wrote: >> 3. leave the code as is, but delay it until our next major version and >> have it as a 'breaking change' (although i guess most users will not be >> happy with this) > > That seems like an unnecessary delay ;-) > _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel