sent some comments as replies to individual patches, rest LGTM - but only read and build-tested so far. I'll try to give this (or a subsequent v3) an actual spin this week as well if time permits.
On Tue, Jun 11, 2019 at 07:36:25PM +0200, Thomas Lamprecht wrote: > v2 with a few more patches and some changes regarding Fabian's feedback > (thanks) from the initial RFC version[0]. > > Last two patches, both new, aren't really tested by me to much, just FYI, > the others seen mostly reasonable adaptions and got smoke-tested for them, as > I > looked more close last time (sorry, trying to fit quite much in my schedule, > currently). > > [0]: https://pve.proxmox.com/pipermail/pve-devel/2019-May/037169.html > > Thomas Lamprecht (8): > corosync config: support 'linknumber' property > add new corosync-link format > cluster create: use new corosync-link format for totem interfaces > corosync: allow to set link priorities > node join: use new corosync link parameters > remove now unused old corosync ringX_addr formats > allow to create a cluster with all possible knet links > api: join/add: generalize and allow all knet links > > data/PVE/API2/ClusterConfig.pm | 85 ++++++++++++++-------------------- > data/PVE/CLI/pvecm.pm | 15 ++++-- > data/PVE/Cluster.pm | 72 +++++++++++++++++++++++++--- > data/PVE/Corosync.pm | 59 ++++++++++++----------- > 4 files changed, 139 insertions(+), 92 deletions(-) > > -- > 2.20.1 > > > _______________________________________________ > pve-devel mailing list > pve-devel@pve.proxmox.com > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
