hi
On Fri, Jul 05, 2019 at 07:00:08PM +0200, Thomas Lamprecht wrote:
> On 7/5/19 1:27 PM, Oguz Bektas wrote:
> > this allows the following mount options for lxc container rootfs or
> > mountpoints:
> > * noatime
> > * nosuid
> > * noexec
> > * nodev
> >
> > Signed-off-by: Oguz Bektas <o.bek...@proxmox.com>
> > ---
> > v3:
> > no change, added for convenience when applying
> >
>
> applied, but moved the field to the left column, see followup commit
> message.
>
> Two improvement ideas:
> * combogrid with short description of flag
ok!
> * more important: implement pending changes for CT, that would be
> great!
i'll take the bug on bugzilla and start working on it soon, once i
finish up some other stuff.
>
> >
> > www/manager6/lxc/MPEdit.js | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
> > index c7c3870a..e33cf54d 100644
> > --- a/www/manager6/lxc/MPEdit.js
> > +++ b/www/manager6/lxc/MPEdit.js
> > @@ -29,6 +29,9 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
> >
> > var confid = me.confid || "mp"+values.mpid;
> > values.file = me.down('field[name=file]').getValue();
> > + if (values.mountoptions) {
> > + values.mountoptions = values.mountoptions.join(';');
> > + }
> >
> > if (me.unused) {
> > confid = "mp"+values.mpid;
> > @@ -52,6 +55,9 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
> > var me = this;
> > var vm = this.getViewModel();
> > vm.set('mptype', mp.type);
> > + if (mp.mountoptions) {
> > + mp.mountoptions = mp.mountoptions.split(';');
> > + }
> > me.setValues(mp);
> > },
> >
> > @@ -275,6 +281,21 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
> > allowBlank: true
> > },
> > {
> > + xtype: 'proxmoxKVComboBox',
> > + name: 'mountoptions',
> > + fieldLabel: gettext('Mount options'),
> > + deleteEmpty: false,
> > + comboItems: [
> > + ['noatime', 'noatime'],
> > + ['nodev', 'nodev'],
> > + ['noexec', 'noexec'],
> > + ['nosuid', 'nosuid']
> > + ],
> > + multiSelect: true,
> > + value: [],
> > + allowBlank: true
> > + },
> > + {
> > xtype: 'proxmoxcheckbox',
> > inputValue: '0', // reverses the logic
> > name: 'replicate',
> >
>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
