a few issues , we talked with wolfgang off-list so he'll send a v3.
* target directories are not created when hotplugging * apparmor profile needs to be adapted * missing case for hotplugging unused disks, they are currently registered as a change and not a new mount, the code doesn't handle that * nitpicks on function names :P On Wed, Nov 13, 2019 at 10:33:10AM +0100, Wolfgang Bumiller wrote: > Changes: > Add a helper to LXC::PVE::Tools to check for availability of the new > mount api (new patch 1), and use that in the prestart hook and mount > functions. > Add a check to the mount hotplug code to not attempt to perform > hotplugging on older kernels. > > Wolfgang Bumiller (9): > tools: add can_use_new_mount_api helper > implement "staged mountpoints" > add open_pid_fd, open_lxc_pid, open_ppid helpers > split open_namespace out of enter_namespace > add get_container_namespace helper > add mount stage directory helpers > prestart-hook: use staged mountpoints on newer kernels > config: vmconfig_apply_pending_mountpoint helper > implement mountpoint hotplugging > > src/PVE/LXC.pm | 180 ++++++++++++++++++++++++++++++++++++-- > src/PVE/LXC/Config.pm | 91 +++++++++++++------ > src/PVE/LXC/Tools.pm | 18 ++++ > src/lxc-pve-prestart-hook | 74 +++++++++++++--- > 4 files changed, 318 insertions(+), 45 deletions(-) > > -- > 2.20.1 > _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel