instead of silently ignoring the change

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
 PVE/API2/Role.pm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm
index 83e4a9d..70a92b6 100644
--- a/PVE/API2/Role.pm
+++ b/PVE/API2/Role.pm
@@ -126,11 +126,14 @@ __PACKAGE__->register_method ({
     code => sub {
        my ($param) = @_;
 
+       my $role = $param->{roleid};
+
+       die "auto-generated role '$role' cannot be modified\n"
+           if PVE::AccessControl::role_is_special($role);
+
        PVE::AccessControl::lock_user_config(
            sub {
 
-               my $role = $param->{roleid};
-
                my $usercfg = cfs_read_file("user.cfg");
 
                die "role '$role' does not exist\n"
-- 
2.20.1


_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to