Robert Latham wrote:
On Thu, May 18, 2006 at 05:10:34PM +0200, Phil Carns wrote:

Index: pvfs2_src/src/server/perf-mon.sm
===================================================================
--- pvfs2_src/src/server/perf-mon.sm    (revision 1541)
+++ pvfs2_src/src/server/perf-mon.sm    (revision 1542)


Am i reading it right that you are now filling in
mgmt_perf_mon.perf_array backwards?  Nothing in the code cares which
way you fill it in?

The code does care which way it is filled in :) My previous patch a few months ago that reworked some of the performance monitoring components accidentally reversed it from the way the response structure was ordered originally. This patch puts it back the right way (ie, in the order that Karma expects).

When I contributed the earlier patch I didn't notice that I had gotten the order wrong, because the test program I was using only ended up getting 1 interval most of the time (I couldn't get Karma to run at the time for some reason).

-Phil
_______________________________________________
Pvfs2-developers mailing list
Pvfs2-developers@beowulf-underground.org
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers

Reply via email to