Re: [Pvfs2-developers] [PATCH 1/2] destdir

[Sam Lang]

On Mar 14, 2008, at 2:48 PM, Pete Wyckoff wrote:

[EMAIL PROTECTED] wrote on Fri, 14 Mar 2008 14:32 -0500:

On Mar 14, 2008, at 2:20 PM, Pete Wyckoff wrote:

# define a few generic variables that we need to use
-DESTDIR =
srcdir = @srcdir@
-prefix = $(DESTDIR)@prefix@
-datarootdir = $(DESTDIR)@datarootdir@
-mandir = $(DESTDIR)@mandir@
-exec_prefix = $(DESTDIR)@exec_prefix@
+prefix = @prefix@
+exec_prefix = @exec_prefix@
+includedir = $(DESTDIR)/@includedir@
+mandir = $(DESTDIR)/@mandir@
+sbindir = $(DESTDIR)/@sbindir@
+bindir = $(DESTDIR)/@bindir@
+libdir = $(DESTDIR)/@libdir@

removed, but then these new definitions still depend on it.

Am I missing something? It looks like the DESTDIR definition is getting

Make magic.  Undefined is empty.  I guess we can leave it in as
above with no harm, but we don't expect people to set it in the
makefile.  An rpm might do something like:

   make install DESTDIR=/tmp/install/path
   ... tar up files from there into the package ...

-sam (painting the shed today)

Ah ok. In that case, $(DESTDIR)@includedir@ makes more sense to me, but I guess it doesn't matter.

                -- Pete

smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Pvfs2-developers mailing list
Pvfs2-developers@beowulf-underground.org
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers