[EMAIL PROTECTED] wrote on Tue, 25 Mar 2008 14:01 -0500:
> Attached patch adds the lock around the getattr for revalidate. It also
> includes some cleanup to the d_revalidate function for my sanity.
Looks good to me. I didn't study all the whitespace changes in
detail.
> Index: src/kernel/linux-2.6/dcache.c
> [..]
> + gossip_debug(GOSSIP_DCACHE_DEBUG, "%s: parent not found.\n",
> __func__);
> + return 0; /* not valid */
I see that 0 is bad a few places here.
> + gossip_debug(GOSSIP_DCACHE_DEBUG,
> + "%s: getattr %s (ret = %d), returning %s for dentry\n",
> + __func__,
> + (ret == 0 ? "succeeded" : "failed"),
> + ret,
> + (ret == 0 ? "valid" : "INVALID"));
> +
> + return ((ret == 0) ? 1 : 0);
But now 0 is good and 1 is bad. As long as you have it all
straight in your head. Maybe some "goto out" would help to
clean all this up, or not.
I certainly enjoy that it will tell you "failed" and "INVALID" in
the same error message. Way to reinforce those negatives. :)
-- Pete
_______________________________________________
Pvfs2-developers mailing list
Pvfs2-developers@beowulf-underground.org
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
