On 7 July 2012 16:06, Benjamin Peterson <benja...@python.org> wrote: > 2012/7/7 Floris Bruynooghe <f...@devork.be>: >> While I was fixing issue #168 I was wondering if it does not make >> sense to make the PYTEST_TAG variable (in _pytest.assertion.rewrite) >> available on the public API? Python itself has imp.get_tag(), so >> maybe pytest.get_tag() is a reasonable name? > > I assume you wanted this because you were using the tag in your test.
Not really, I was just drawing the parallel with imp.get_tag() which is also largely an implementation detail but still available. I have no problem with not providing it however. > test_rewrite.py is allowed to dig into the internals, so what you did > was completely acceptable. Sure, I have no problems with the test. (Btw, apologies for not following the file's style properly and not spotting where the internal imports where done, I shouldn't have written that is such a rush) Regards, Floris _______________________________________________ py-dev mailing list py-dev@codespeak.net http://codespeak.net/mailman/listinfo/py-dev
