On 29/04/2006, at 6:11 AM, Lars T. Mikkelsen wrote: > Hi Maarten, > > On Thu, Apr 27, 2006 at 08:47:24PM +0200, Maarten Fonville wrote: >> I suspect that the problem could be that the nickname field has been >> send after the fullname field and so the name will be empty(!) and so >> the updateNickName method will use the JID user part for nickname. > > I checked the vCard sent by the Google Talk server, and it does in fact > not contain a <NICKNAME/> element. However, I agree that there might be > an issue if the vCard contains an empty <NICKNAME/> after an non-empty > <FN/>. > > I found a bug a couple of lines below the snippet you posted, that > prevents the nickname from being set properly in some cases. The > attached patch fixes the issue. > >> James, could you please fix this, I suspect that putting an "not name >> and " part before the NICKNAME 'if' will do the trick > > By doing this we'll lose the priority of <NICKNAME/> over <FN/> if the > vCard contains an <FN/> after the <NICKNAME/>. > > Best regards, > Lars
Thanks. Both issues should be fixed in latest SVN. --- James
