On 02/01/2006, at 7:23 AM, Lars T. Mikkelsen wrote:
> On Sun, Jan 01, 2006 at 11:08:00PM +1100, James Bunton wrote:
>> Could people please help me test things. I'm looking for regressions
>> in
>> particular. A lot of code has been completely rewritten. So things
>> like
>> groupchat, clientcaps, avatars and even ordinary messaging still need
>> a
>> bit of edge-case testing.
>
> So far I found two minor issues with avatars:
>
> 1) The 0.11 branch allowed one to configure the getAllAvatars
> behaviour in
> config.xml. In trunk getAllAvatars is present in src/config.py and
> config-example.xml, but config.getAllAvatars is not actually used. The
> attached
> patch replaces GETALLAVATARS with config.getAllAvatars.
Thanks for finding this :)
Should be fixed now. SVN trunk v78 :)
> 2) The avatar hash is not always properly base64-decoded, and thus the
> AvatarCache fails to fetch avatars:
>
> 2006/01/01 20:47 CET [NotificationClient,client] INFO :: :: ::
> contactAvatarChanged :: <tlib.msn.msnw.NotificationClient instance at
> 0xb75b1a6c> :: {'self': <tlib.msn.msnw.NotificationClient instance at
> 0xb75b1a6c>, 'hash': '2st/sKrrNgIW+/sHsFeE3FT0QQ8=', 'userHandle':
> '<contact's passport>'}
> 2006/01/01 20:47 CET [NotificationClient,client] INFO :: <my JID> ::
> :: contactAvatarChanged :: <legacy.glue.LegacyConnection instance at
> 0xb77b8c8c> :: {'self': <legacy.glue.LegacyConnection instance at
> 0xb77b8c8c>, 'hash': '2st/sKrrNgIW+/sHsFeE3FT0QQ8=', 'userHandle':
> '<contact's passport>'}
> 2006/01/01 20:47 CET [NotificationClient,client] INFO :: :: Avatar
> not found. :: getAvatarData :: <avatar.AvatarCache instance at
> 0xb7600e0c> :: {'self': <avatar.AvatarCache instance at 0xb7600e0c>,
> 'key': '2st/sKrrNgIW+/sHsFeE3FT0QQ8=', 'filename':
> '[...]/avatars/2st/2st/sKrrNgIW+/sHsFeE3FT0QQ8='}
> 2006/01/01 20:47 CET [NotificationClient,client] INFO :: <my JID> ::
> :: sendAvatarRequest :: <legacy.glue.LegacyConnection instance at
> 0xb77b8c8c> :: {'self': <legacy.glue.LegacyConnection instance at
> 0xb77b8c8c>, 'userHandle': '<contact's passport>'}
Thanks for that :)
Fixed in SVN trunk v81 :)
---
James
