On 21/02/2006, at 8:31 AM, Lars T. Mikkelsen wrote: > On Sat, Feb 18, 2006 at 06:58:53PM +0100, Lars T. Mikkelsen wrote: >>> Please direct any bug reports to the [email protected] >>> mailing list. I'm more likely to miss something in jadmin or jdev >>> when >>> I get back. >> >> I have some very minor issues with the latest release - I'm sorry I >> didn't have the time to report these before you made the actual >> release. >> >> * A LogEvent() on message errors that course removal of the session >> would be nice. (I.e. a LogEvent() just before s.removeMe() in >> PyTransport.onMessage()). >> * The session should also be removed on presence errors - just like on >> message errors. >> * The transport doesn't properly handle presence probes to the >> transport >> itself (i.e. to config.jid) - these return an 'unavailable' status. > > I forgot to mention this: > > * I haven't actually observed this (so I might be wrong), but I think > there is a risk that PyTransport.onMessage() will respond to an error > message with an error message (which is prohibited by RFC 3920, > Section 9.3.1). I guess the last 'else:' statement should be 'elif > mtype != "error":' - this is also the behaviour of rev. 105 and > prior. > > Best regards, > Lars
Thanks. Fixed. --- James
